Add ignoreUndefined flag for rename() by JbIPS · Pull Request #616 · hapijs/joi

JbIPS · 2015-03-25T15:54:36Z

Add a flag to ignore a missing key when renaming it.

var schema = Joi.object().rename('b', 'a', { ignoreUndefined: true });

            var input = {
                a: 'something'
            };

            schema.validate(input, function (err, value) {

               // input : {a: 'something'}
            });

close #614

AdriVanHoudt · 2015-03-25T16:11:27Z

test/object.js

isn't it easier to do expect(value).to.deep.equal({ a: 'something' })?

That's right, I just copied/paste https://github.com/JbIPS/joi/blob/master/test/object.js#L652.
If you think deep.equal() is better, I'll change it

it will make sure that if you tamper with the test and add an extra key or something the test itself will still want to same result. in your case the results needs to have key a but it can aswell have key b. I don't think it is a major thing but it also improves readability imo

Ok, the new test is here :)

AdriVanHoudt · 2015-03-25T16:11:42Z

👍

Marsup · 2015-03-25T22:27:09Z

lib/object.js

Space before brace.

Marsup · 2015-03-25T22:31:14Z

To avoid future regressions can you also add tests combining this flag with override true ? And also add that flag to the docs. Thanks !

JbIPS · 2015-03-26T09:10:37Z

Added a cross test with override and rebased to enable auto merge :)

AdriVanHoudt · 2015-03-26T09:13:20Z

nice work!

Add ignoreUndefined flag for rename()

Marsup · 2015-03-26T09:25:14Z

Thanks !

JbIPS · 2015-03-26T09:50:58Z

Thanks! Just one little question, when do you think this will be released? Just to know when I could go back to "joi": "6.1.0" on my package :)

Marsup · 2015-03-26T09:52:22Z

Finishing the work on IP validation then .

lock · 2020-01-09T13:44:33Z

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

AdriVanHoudt reviewed Mar 25, 2015
View reviewed changes

Marsup reviewed Mar 25, 2015
View reviewed changes

lib/object.js Outdated

Copy link

Collaborator

Marsup Mar 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before brace.

jbrichardet added 3 commits March 26, 2015 10:06

Add ignoreUndefined flag for rename()

9d79cb0

Change to deep equals for test

4ec9418

Add test + doc

85c2d4a

JbIPS force-pushed the master branch from aa0b129 to 85c2d4a Compare March 26, 2015 09:07

Marsup added a commit that referenced this pull request Mar 26, 2015

Merge pull request #616 from JbIPS/master

675af0f

Add ignoreUndefined flag for rename()

Marsup merged commit 675af0f into hapijs:6.1.0 Mar 26, 2015

Marsup added the feature New functionality or improvement label Mar 26, 2015

Marsup added this to the 6.1.0 milestone Mar 26, 2015

Marsup self-assigned this Mar 26, 2015

lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020

Conversation

JbIPS commented Mar 25, 2015

Uh oh!

AdriVanHoudt Mar 25, 2015

Choose a reason for hiding this comment

Uh oh!

JbIPS Mar 25, 2015

Choose a reason for hiding this comment

Uh oh!

AdriVanHoudt Mar 25, 2015

Choose a reason for hiding this comment

Uh oh!

JbIPS Mar 25, 2015

Choose a reason for hiding this comment

Uh oh!

AdriVanHoudt commented Mar 25, 2015

Uh oh!

Marsup Mar 25, 2015

Choose a reason for hiding this comment

Uh oh!

Marsup commented Mar 25, 2015

Uh oh!

JbIPS commented Mar 26, 2015

Uh oh!

AdriVanHoudt commented Mar 26, 2015

Uh oh!

Marsup commented Mar 26, 2015

Uh oh!

JbIPS commented Mar 26, 2015

Uh oh!

Marsup commented Mar 26, 2015

Uh oh!

lock bot commented Jan 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants