Skip to content

deprecate array.includes and array.excludes, use array.items and allow required and forbidden within#559

Merged
Marsup merged 1 commit intomasterfrom
array_includes_required
Feb 25, 2015
Merged

deprecate array.includes and array.excludes, use array.items and allow required and forbidden within#559
Marsup merged 1 commit intomasterfrom
array_includes_required

Conversation

@nlf
Copy link
Member

@nlf nlf commented Feb 20, 2015

I think this is ready now..

  • adds array.items() which accepts both .required() and .forbidden() items
  • removes array.includes()
  • removes array.excludes()
  • changes array.describe() output to contain only an items array rather than includes and excludes

Marsup
Marsup reviewed Feb 20, 2015
View reviewed changes
lib/array.js Outdated
Copy link
Collaborator

@Marsup Marsup Feb 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concat can take multiple args

@Marsup Marsup added feature New functionality or improvement breaking changes Change that can breaking existing code labels Feb 21, 2015
@Marsup Marsup added this to the 6.0.0 milestone Feb 21, 2015
@Marsup Marsup self-assigned this Feb 21, 2015
Marsup
Marsup reviewed Feb 21, 2015
View reviewed changes
lib/array.js Outdated
Copy link
Collaborator

@Marsup Marsup Feb 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use slice instead, we don't need a deep clone here

@Marsup Marsup mentioned this pull request Feb 21, 2015
Closed
@nlf nlf force-pushed the array_includes_required branch from 99a28e7 to 5daf892 Compare February 21, 2015 20:57
@nlf nlf changed the title WIP: allow for required() in array.includes WIP: deprecate array.includes and array.excludes, use array.items and allow required and forbidden within Feb 25, 2015
@nlf nlf force-pushed the array_includes_required branch from 4327639 to 7dbcc48 Compare February 25, 2015 19:48
@nlf nlf changed the title WIP: deprecate array.includes and array.excludes, use array.items and allow required and forbidden within deprecate array.includes and array.excludes, use array.items and allow required and forbidden within Feb 25, 2015
Marsup
Marsup reviewed Feb 25, 2015
View reviewed changes
test/array.js Outdated
Copy link
Collaborator

@Marsup Marsup Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlf includes -> items

@nlf
move to array.items, closes #554
02d6581 
deprecates array.includes and array.excludes
allows for use of required() and forbidden() in items list
@nlf nlf force-pushed the array_includes_required branch from 7dbcc48 to 02d6581 Compare February 25, 2015 22:29
Marsup added a commit that referenced this pull request Feb 25, 2015
@Marsup
Merge pull request #559 from hapijs/array_includes_required
352a5ac 
deprecate array.includes and array.excludes, use array.items and allow required and forbidden within
@Marsup Marsup merged commit 352a5ac into master Feb 25, 2015
@Marsup Marsup deleted the array_includes_required branch February 25, 2015 23:52
@dbrockman dbrockman mentioned this pull request May 27, 2015
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking changes Change that can breaking existing code feature New functionality or improvement

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nlf @Marsup