Skip to content

added number.multiple()#538

Merged
Marsup merged 4 commits intohapijs:masterfrom
johnbrett:master
Feb 4, 2015
Merged

added number.multiple()#538
Marsup merged 4 commits intohapijs:masterfrom
johnbrett:master

Conversation

@johnbrett
Copy link
Contributor

@johnbrett johnbrett commented Jan 29, 2015

This pull request adds the number.multiple() validation option as mentioned in this issue: #532.

(I saw this tagged under new contributors on http://hapijs.com/contribute)

Marsup
Marsup reviewed Feb 2, 2015
View reviewed changes
lib/number.js Outdated
Copy link
Collaborator

@Marsup Marsup Feb 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a simple string, this has to be defined in language.

@johnbrett
Copy link
Contributor Author

johnbrett commented Feb 2, 2015

Thanks for the feedback on the PR @Marsup!

Marsup
Marsup reviewed Feb 3, 2015
View reviewed changes
lib/language.js
Copy link
Collaborator

@Marsup Marsup Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this alpha sorted ?

@johnbrett
Copy link
Contributor Author

johnbrett commented Feb 3, 2015

Hi @Marsup, would you prefer that multiple is moved above negative, or that I reorder the number object fully? I'm not sure I understand the ordering, e.g. base, min, max, less, greater .. does the sorting begin after float?

Thanks again for feedback also.

@Marsup
Copy link
Collaborator

Marsup commented Feb 3, 2015

Sorry I thought it was already the case, ignore that then.

@johnbrett
Copy link
Contributor Author

johnbrett commented Feb 3, 2015

No worries, anything else needed to be merged?

@Marsup Marsup added the feature New functionality or improvement label Feb 3, 2015
@Marsup Marsup self-assigned this Feb 3, 2015
Marsup
Marsup reviewed Feb 3, 2015
View reviewed changes
lib/number.js Outdated
Copy link
Collaborator

@Marsup Marsup Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after if.

@Marsup
Copy link
Collaborator

Marsup commented Feb 3, 2015

I'll merge after those last 2.

@Marsup Marsup added this to the 6.0 milestone Feb 3, 2015
Marsup added a commit that referenced this pull request Feb 4, 2015
@Marsup
Merge pull request #538 from johnbrett/master
5ae6c48 
Add number.multiple()
@Marsup Marsup merged commit 5ae6c48 into hapijs:master Feb 4, 2015
@AdriVanHoudt AdriVanHoudt mentioned this pull request Feb 5, 2015
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Marsup Marsup

Labels

feature New functionality or improvement

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@johnbrett @Marsup