Make alternatives.describe more consistent#513
Merged
Marsup merged 2 commits intohapijs:masterfrom Dec 12, 2014
Merged
Conversation
Fixes hapijs#211 Updates alternatives.describe from an array of descriptions to use the proposed `{ type: 'alternatives', alternatives: [...] }` syntax with all of the fields supported by `Any` included.
Collaborator
|
Can you add a test testing what #211 was complaining about ? |
Author
|
Sure, I can get that updated tonight. On Thursday, December 11, 2014, Nicolas Morel notifications@github.com
Doug McCall |
Author
|
@Marsup Added a unit test to validate |
Author
|
Looks like the travis builds failed due to an npm issue |
Marsup
added a commit
that referenced
this pull request
Dec 12, 2014
Make alternatives.describe more consistent
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
Updates alternatives.describe from an array of descriptions to use the
proposed
{ type: 'alternatives', alternatives: [...] }syntax withall of the fields supported by
Anyincluded.