Retain object reference when no rules specified#478
Merged
Conversation
Collaborator
|
Nice and useful indeed. Why the bug label though ? |
Marsup
added a commit
that referenced
this pull request
Nov 7, 2014
Retain object reference when no rules specified
Contributor
Author
|
It's a bug because at every other level, joi keeps the existing value unless it needs to do a deep copy. It shallow copies objects but the behavior is not what I expected it to be (and I wrote this shit) when there is nothing to verify. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few places in hapi config where we validate an options object containing user-specified values like
app. These are shallow copied even when there is no reason to (no other rules specified). This creates a simple shortcut when there is no reason to perform even a shallow copy. Without this, the type must be set tojoi.any()which is not as good asjoi.object().