Conversation
Signed-off-by: Richard Tomlinson <richard.tomlinson@matchesfashion.com>
Signed-off-by: Richard Tomlinson <richard.tomlinson@matchesfashion.com>
|
@Marsup can your date change using moment going to cover this too? I rather not do any of this work if we are going to include another module. |
|
@hueniverse moment does support ISO 8061 and I don't see any opened issue about it so probably, still the tests in this PR can be interesting to take. |
|
@hueniverse btw |
|
For now, yeah. Not a great reason for a breaking change. I would keep it but remove it from the docs... |
|
It passes the tests, but it also accepts |
|
I would rather remove the regex and use moment instead for this too. |
|
@Marsup W3s interpretation of ISO 8061 doesn't allow for timestamps without a timezone identifier, either Z, to indicate UTC, or an offset are required. Extending the |
|
@rtomlinson that might be good you create an issue for that on moment if you really care about it. |
|
Going to close this issue. @Marsup can you reference it in your new pr? |
|
Will do. For the record it also validates |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Updated the RegEx to support yyyy-mm-dd, it also removes a defect which allowed strings such as '2013-06-07T14:21:46.295Z0' to pass validation.
This brings it closer to W3s interpretation of ISO 8061 (http://www.w3.org/TR/NOTE-datetime), but is still not strictly compliant.