Added check for global flag in pattern.#397
Merged
geek merged 1 commit intohapijs:masterfrom Aug 14, 2014
Merged
Conversation
Member
Migration stepChange any global regex |
geek
added a commit
that referenced
this pull request
Aug 14, 2014
Added check for global flag in pattern.
Contributor
|
This is the wrong solution. First, we also need to handle string.regex() which has the same issue. Second, global flag means nothing for validation because it is always called once per string. Instead of a breaking change, it would be better to remove the global flag from the expression, at least for 4.x. We can make a breaking change in 5.x by no longer allowing it. There is also the sticky flag which I am not even sure how it works. So to be safe, we should always create a new regex and only copy the i flag over. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you had /g in your
patternoption, the results ofpattern.regex.test(key)here will toggle back and forth betweentrueandfalsecreating very unpredictable validation results.Read up about this design decision http://stackoverflow.com/a/1520853/1011616
I'm not sure what to do about the versioning of this. If you're using a
patternfunction with "/g" then this is going to break your code.