Skip to content

feat(d.ts): improve attempt return type#2797

Merged
Marsup merged 2 commits intohapijs:masterfrom
mfulton26:attempt-d.ts
Sep 17, 2022
Merged

feat(d.ts): improve attempt return type#2797
Marsup merged 2 commits intohapijs:masterfrom
mfulton26:attempt-d.ts

Conversation

@mfulton26
Copy link
Contributor

joi.attempt can return a template type rather than any

Closes #2643

`joi.attempt` can return a template type rather than `any`

Closes hapijs#2643
Copy link

@lxcid lxcid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Marsup Marsup self-assigned this Sep 17, 2022
@Marsup Marsup added the types TypeScript type definitions label Sep 17, 2022
@Marsup Marsup added this to the 17.6.1 milestone Sep 17, 2022
@Marsup Marsup merged commit 3845608 into hapijs:master Sep 17, 2022
Marsup added a commit that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

types TypeScript type definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typescript types to Joi.attempt

3 participants