Find full path to nested errors#206
Merged
hueniverse merged 1 commit intohapijs:masterfrom Apr 22, 2014
Merged
Conversation
Contributor
|
Given recent changes, I'm going to incorporate #202 into the fixes planned. |
Contributor
Author
|
Fair enough, thanks! |
hueniverse
pushed a commit
that referenced
this pull request
Apr 22, 2014
Find full path to nested errors
Contributor
|
I had to undo most of it. The problem is that this solves a very narrow problem and only when the reason is flat. Need to go deeper in order to retail the full chain of paths, but I think this is not bad. |
Contributor
Author
|
I was pretty unsure about that – thanks for pushing this through! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not at all sure if this is the cleanest implementation, but it does do the job. I'd happy take a cleaner implementation that doesn't require recursion.
Fixes #202