Allows using any.rename() and any.default() together#201
Merged
hueniverse merged 3 commits intohapijs:masterfrom Mar 20, 2014
Merged
Allows using any.rename() and any.default() together#201hueniverse merged 3 commits intohapijs:masterfrom
hueniverse merged 3 commits intohapijs:masterfrom
Conversation
Contributor
|
This is not the right solution. It should first set the default value in _validate and then do the rename. |
Contributor
Author
|
Sure thing! I will fix that! |
Contributor
Author
|
Hey @hueniverse, Changing the order of the Any._validate.finish() implementation to apply the mutators after setting the value, works properly. What do you think? |
hueniverse
pushed a commit
that referenced
this pull request
Mar 20, 2014
Allows using any.rename() and any.default() together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
With this Joi object:
{ foo: Joi.string().rename('foo2').default('test') }And the input value:
{}The validation should output:
But was outputting: