Added the ability to use a reference for Array min/max/length#1206
Merged
DavidTPate merged 1 commit intohapijs:masterfrom Jun 12, 2017
DavidTPate:array-length-ref
Merged
Added the ability to use a reference for Array min/max/length#1206DavidTPate merged 1 commit intohapijs:masterfrom DavidTPate:array-length-ref
DavidTPate merged 1 commit intohapijs:masterfrom
DavidTPate:array-length-ref
Conversation
WesTyler
approved these changes
Jun 1, 2017
| ```js | ||
| const schema = Joi.object({ | ||
| length: Joi.number().integer().required(), | ||
| numbers: Joi.array().length(Joi.ref('limit')).required() |
Contributor
There was a problem hiding this comment.
Copy pasta got you ;)
Joi.ref('limit') vs Joi.ref('length')
| arr: [1, 2] | ||
| }, false, null, 'child "arr" fails because ["arr" references "limit" which is not a number]'], | ||
| [{ | ||
| limit: 'I like turtles', |
`array().min(), and `array().max()`. Fixes #1017
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a user to use a reference for
array().length(),array().min()andarray().max()as well as adding test cases and documentation around the functionality.Fixes #1017