Internal rewrite to async / await#97
Merged
hueniverse merged 3 commits intohapijs:masterfrom Sep 19, 2017
Merged
Conversation
hueniverse
added a commit
that referenced
this pull request
Sep 20, 2017
Contributor
|
@kanongil see my follow up commit. |
Contributor
Author
|
Look good. Shouldn't the |
Contributor
|
Yes, also marshal and prepare... This is a deep rabbit hole... |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All internal logic has been rewritten to use
async/await.It is still targets hapi@16 for the interface, but should be simple to update. To fully target v17, all tests needs to be rewritten.