Avoid re-opening files when serving from a directory#42
Merged
kanongil merged 1 commit intohapijs:masterfrom Oct 2, 2015
Merged
Avoid re-opening files when serving from a directory#42kanongil merged 1 commit intohapijs:masterfrom
kanongil merged 1 commit intohapijs:masterfrom
Conversation
kanongil
added a commit
that referenced
this pull request
Oct 2, 2015
Avoid re-opening files when serving from a directory
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
preparephase is inadvertently called twice for the same file when served via the directory handler.This patch fixes the issue by skipping the prepare phase once the response has been submitted. I have added an additional test to verify this behavior.
This issue is mostly a performance problem, though it can in extreme cases cause incorrect behavior if the file is moved / deleted between the two calls to the
preparefunction.