Merged
Conversation
Contributor
Author
|
PR updated with a deferred callback mechanism to prevent multiple hashings on the same file. |
lib/etag.js
Outdated
Contributor
There was a problem hiding this comment.
Change callback to next since it is not always called on next tick or if it needs to be consistent, use Hoek.nextTick().
Contributor
|
See comments. Otherwise looks good. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
etagMethodoption to the file and directory handlers, as suggested in #29:etagMethod- specifies the method used to calculate theETagheader response. Available values:'hash'- SHA1 sum of the file contents, suitable for distributed deployments. Default value.'simple'- Hex encoded size and modification date, suitable when files are only stored on a single server.false- Disable ETag computation.Note that this changes the behavior of the default hashing method to always return an
ETagheader. This requires uncached etags to be computed in the prepare step, which translates to some extra latency in such requests, while the file is hashed. I don't believe that this should cause problems for most common use-cases and can actually improve performance in some cases (eg. cachedif-none-matchrequests against a freshly started server can now serve a 304 response).