Fix directory handler regressions in 2.1.1#19
Merged
hueniverse merged 3 commits intohapijs:masterfrom Jan 26, 2015
Merged
Conversation
Fixes incorrect redirect response for permissionless files and other file open errors
Contributor
There was a problem hiding this comment.
If you are going to perform this check on every success case, why not move it up before the open operation which is more expensive?
Contributor
Author
There was a problem hiding this comment.
I placed it where it is, since it will only be called for what would otherwise be a internal error. This way it won't have any impact on normal responses.
Contributor
There was a problem hiding this comment.
Ok. Comment should start with a Cap :-)
Contributor
Author
There was a problem hiding this comment.
Ok, I'll remember that :-)
hueniverse
pushed a commit
that referenced
this pull request
Jan 26, 2015
Fix directory handler regressions in 2.1.1
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.