Note that doing actual validation means that the boolean values will be handled slightly different for string input. Previously, "false" would pass the assertion check but actual usage evaluates it to true.

Is this a bug fix then? or breaking change?

Good question. I did this as a refactor, and only realized the slightly changed behavior afterwards.

The issue is actually a bit trickier than it would seem. I'm inclined towards labelling the non-assertion for Joi.assert("false", Joi.boolean()) as a bug in joi, as it will likely produces weird results without conversion as well. I'm not sure how you would fix it though. Maybe @Marsup can provide some insight?

'false' is a valid boolean value in joi with the default settings. The problem here is that the value is allowed but the casting is not preserved leading to invalid settings. I think the change is more about Joi.assert(). Either we change the defaults to strict mode, or change how we use it by keeping the validated result.

Either way, I would call this a bug fix for inert.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.