I prefer this was much simpler. server.decorations as a property. Since you cannot un-decorate, keeping such a public property up to date should be trivial.

Agreed, will revisit this approach.

@hueniverse just for clarification, are you suggesting:

server.decorations
request.decorations
reply.decorations

Or

server.decorations = {
  server: <decorations>,
  request: <decorations>,
  reply: <decorations>
}

The latter makes more sense to me.

@devinivy any particular reason why?

Yes– it's hard to get a hold of a request object or reply interface simply to check if they're decorated with a specific method. Decorations are (probably!) added at plugin registration time, so I think they should be able to be introspected at plugin registration time as well.

Ok I agree. Why not both? if you want to check on request you'd have to go request.server.decorations.request[] :P

Just server.decorations.

@AdriVanHoudt I would omit that for the express purpose of keeping the features of the API independent of each other. Plus, if you already have a request object you can just check for the decorated method directly on it!

@hueniverse is this approach more inline?

I'll review it in a week or two.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.