Skip to content

add set/clear key for cookie#30

Merged
hueniverse merged 3 commits intohapijs:masterfrom
Icehunter:master
Nov 12, 2014
Merged

add set/clear key for cookie#30
hueniverse merged 3 commits intohapijs:masterfrom
Icehunter:master

Conversation

@Icehunter
Copy link
Copy Markdown
Contributor

This would reference issue/request:
#26

Unless I was doing it wrong however in using the original implementation I could never set request.auth.artifacts and retain that through the session lifecycle.

With this change though you can manipulate the data and add/remove at will. Personally I've been using this for validation tokens when posting data and clearing it out after to prevent spam.

@Icehunter
Copy link
Copy Markdown
Contributor Author

Forgive the tests... they didn't get pushed. Adding now.

Update:
Sorry I noticed something else I should be doing with this and I'll fix up the commit. Apologies.

key should at least be a non-empty string
@hueniverse hueniverse added the feature New functionality or improvement label Nov 12, 2014
@hueniverse hueniverse self-assigned this Nov 12, 2014
@hueniverse hueniverse added this to the 1.3.3 milestone Nov 12, 2014
hueniverse pushed a commit that referenced this pull request Nov 12, 2014
add set/clear key for cookie
@hueniverse hueniverse merged commit 71a8c0a into hapijs:master Nov 12, 2014
hueniverse pushed a commit that referenced this pull request Nov 12, 2014
@hueniverse
Copy link
Copy Markdown
Contributor

I changed the API but added the functionality.

@Icehunter
Copy link
Copy Markdown
Contributor Author

Awesome! Thanks so much.

@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants