Skip to content

Exposed path option for session cookie#22

Merged
arb merged 3 commits intohapijs:masterfrom
paulwcy:master
Aug 22, 2014
Merged

Exposed path option for session cookie#22
arb merged 3 commits intohapijs:masterfrom
paulwcy:master

Conversation

@paulwcy
Copy link
Copy Markdown
Contributor

@paulwcy paulwcy commented Aug 15, 2014

Closes #21

@arb
Copy link
Copy Markdown
Contributor

arb commented Aug 15, 2014

Missing tests, hence the failing build.

@arb
Copy link
Copy Markdown
Contributor

arb commented Aug 20, 2014

@paulwcy you did not add or update any tests to show that setting settings.path does anything.

@paulwcy
Copy link
Copy Markdown
Contributor Author

paulwcy commented Aug 22, 2014

@arb I've added the test now. It just ensures that the cookie path is set to the specified value when provided.

@arb arb added this to the 1.3.3 milestone Aug 22, 2014
arb added a commit that referenced this pull request Aug 22, 2014
Exposed path option for session cookie
@arb arb merged commit 76cc5b4 into hapijs:master Aug 22, 2014
@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose 'path' in cookieOptions

3 participants