Improve example in README.md#206
Merged
hueniverse merged 1 commit intohapijs:masterfrom Mar 15, 2019
nanodracula:patch-2
Merged
Improve example in README.md#206hueniverse merged 1 commit intohapijs:masterfrom nanodracula:patch-2
hueniverse merged 1 commit intohapijs:masterfrom
nanodracula:patch-2
Conversation
Hi everyone! This PR aim to improve example code in readme, so that newcomers can more easily understand how to use this module. **I tried to:** - Simplify conditional logic - Break apart login POST and GET handlers - Remove Hapi cache as session storage because you don’t have to know about the cache in order to use this module. Also using this in memory sessions will log out you after server restart, which may confuse people (as example: #200) - Move html templates from handlers
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone!
This PR aim to improve example code in readme, so that newcomers can more easily understand how to use this module.
I tried to: