Skip to content

Do not redecorate the request object if already decorated#152

Merged
jaw187 merged 2 commits intohapijs:masterfrom
gordysc:master
Feb 17, 2017
Merged

Do not redecorate the request object if already decorated#152
jaw187 merged 2 commits intohapijs:masterfrom
gordysc:master

Conversation

@gordysc
Copy link
Copy Markdown
Contributor

@gordysc gordysc commented Dec 17, 2016

I have a separate PR opened against Hapi to allow for someone to check if a request object is already decorated with a method. However, that should only affect people using HapiJS 16.0.X. This PR can be used with previous versions of Hapi, as the underlying logic is still there.

This addresses #119

@gordysc
Copy link
Copy Markdown
Contributor Author

gordysc commented Jan 4, 2017

@jaw187 hope you had a great holiday season! Any shot we could get this merged in/reviewed?

@xGouley
Copy link
Copy Markdown

xGouley commented Jan 25, 2017

+1 this feature should be great...
... Really great... [edit 2016-02-03]
... OK, I fork... [edit 2016-02-06]

@sholladay sholladay mentioned this pull request Feb 12, 2017
@jaw187
Copy link
Copy Markdown
Contributor

jaw187 commented Feb 17, 2017

hapijs/hapi#3409

@jaw187 jaw187 merged commit f697b7a into hapijs:master Feb 17, 2017
@gordysc
Copy link
Copy Markdown
Contributor Author

gordysc commented Feb 24, 2017

@xGouley this has been merged, just waiting on a new version to be released 👍
@jaw187 do we have a timetable of when this will be?

@nlf nlf added this to the 7.0.0 milestone Mar 28, 2017
@nlf nlf added the bug Bug or defect label Mar 28, 2017
@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants