Open
Conversation
c7db8c7 to
8a2663e
Compare
hannesm
reviewed
Jun 4, 2025
Owner
|
this looks fine to me, feel free to merge when you're ready. |
8a2663e to
54bc35c
Compare
54bc35c to
633c37a
Compare
Collaborator
Author
|
Running the full testsuite locally shows the following unsettling performance behaviour: OCaml 5.4:
OCaml 4.14:
|
633c37a to
f28c067
Compare
Collaborator
Author
|
Thanks to a quick godbolt today i learned that (at least for 4.14): doesn't seem to create an equivalent native binary to After splitting #41 away and removing the OCaml 5.4:
OCaml 4.14:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued on #23