Conversation
|
@hannesm what do you think about adding such large files to the repository? They add 40MB to the project uncompressed (3.4MB compressed using gzip). Alternatively we could have another repository to store these kind of test files. |
|
it would be great to have this huge thing external.. maybe a separate git repo, or a download url that is fetched unless it is present during the testrun (if that's possible with dune rules and the opam sandbox) -- could be an extra-files in the opam file (though that won't work for local development).. |
|
Done. I've created a new repository at https://codeberg.org/kit-ty-kate/ocaml-patch-tests, linked it using git submodules and the tests now explicitly skip these if the files are missing or if the platform doesn't support the large strings necessary to load them (e.g. 32bit platforms) |
|
this looks good, thanks. would you mind to document in README what to do for development in terms of git submodule? and does CI test the big file test? |
yes, ocaml-ci fetches every submodules |
done |
Here the diff is between 2025-01-before-archiving-phase1 and 999bff3ed88d26f76ff7eaddbfa7af49ed4737dc from opam-repository
This unlocks parsing large diff files. I'll add tests on Monday.
The first commit alone allows
opam updateof opam-repository at2025-01-before-archiving-phase1tomasterto be made in < 7s (including just 0.1s ofPatch.parse), compared to +infinity (several hours) before.