Merged
Conversation
I feel like they shouldn't be separated given a diff can be an
Edit or a Rename solely based on the prefix number. For example:
```
--- a/a
+++ b/a
```
would be Rename ("a/a", "b/a") but if we're applying it using
`patch -p1` they're equal.
Owner
|
thanks. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 3, 2024
CHANGES: * Add support for git format-patch headers (hannesm/patch#7 @kit-ty-kate) * Pretty-printer: fix no_newline support (hannesm/patch#11 @kit-ty-kate) * Various fixes to the diff parser ('---' mid diff, hunks, no newline at end of file) (hannesm/patch#10 @kit-ty-kate) * Add Patch.pp_list (hannesm/patch#13 @kit-ty-kate) * Merge Edit and Rename operations (hannesm/patch#14 @kit-ty-kate) * Add a diff implementation (hannesm/patch#12 @kit-ty-kate) * Rename to_diffs to parse (hannesm/patch#16 @kit-ty-kate) * Provide API docs, tweak documentation (@hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like they shouldn't be separated given a diff can be an Edit or a Rename solely based on the prefix number. For example:
would be Rename ("a/a", "b/a") but if we're applying it using
patch -p1they're equal.