Skip to content

feat: extract more CSS variables#25

Merged
f2c-ci-robot[bot] merged 5 commits intohalo-dev:mainfrom
jiewenhuang:main
Feb 20, 2024
Merged

feat: extract more CSS variables#25
f2c-ci-robot[bot] merged 5 commits intohalo-dev:mainfrom
jiewenhuang:main

Conversation

@jiewenhuang
Copy link
Copy Markdown
Contributor

@jiewenhuang jiewenhuang commented Feb 19, 2024 •
edited by JohnNiang
Loading

为了更好的适配主题样式，新增以下CSS变量：

--halo-search-widget-font-size-search-form-input:;                     /*输入框字体大小*/
--halo-search-widget-line-height-search-form-input:;                   /*输入框行高*/
--halo-search-widget-font-size-search-form-result-item-title:;         /*搜索结果项标题字体大小*/
--halo-search-widget-line-height-search-form-result-item-title:;       /*搜索结果项标题行高*/
--halo-search-widget-font-size-search-form-result-item-content:;       /*搜索结果项内容字体大小*/
--halo-search-widget-line-height-search-form-result-item-content:;     /*搜索结果项内容行高*/
--halo-search-widget-font-size-search-form-empty:;                     /*搜索结果为空时的字体大小*/
--halo-search-widget-line-height-search-form-empty:;                   /*搜索结果为空时的行高*/
--halo-search-widget-font-size-search-form-commands-item:;             /*搜索框底部快捷键提示字体大小*/
--halo-search-widget-line-height-search-commands-item:;                /*搜索框底部快捷键提示行高*/
--halo-search-widget-font-size-search-form-commands-item-kbd:;         /*搜索框底部快捷键提示图标大小*/ 
--halo-search-widget-min-width-search-commands-item-kbd:;              /*搜索框底部快捷键提示图标 min-wight*/
--halo-search-widget-font-family-search-form:;                         /*搜索框字体*/
新增 CSS 变量以更好地适配主题样式

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby February 19, 2024 06:06
@JohnNiang
Copy link
Copy Markdown
Member

JohnNiang commented Feb 19, 2024

/ping @halo-dev/sig-halo-console

ruibaby
ruibaby requested changes Feb 20, 2024
View reviewed changes
Comment thread packages/search-widget/src/search-form.ts Outdated
@ruibaby ruibaby changed the title add:extract more CSS variables feat: extract more CSS variables Feb 20, 2024
ruibaby
ruibaby reviewed Feb 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 20, 2024
@JohnNiang JohnNiang requested a review from ruibaby February 20, 2024 15:34
JohnNiang
JohnNiang approved these changes Feb 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5b90f5d into halo-dev:main Feb 20, 2024
@ruibaby ruibaby mentioned this pull request Mar 5, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 5, 2024
@ruibaby
refactor: refine css var (#27)
a15b258 
移除在 #25 中提供的字体和行高变量，改为和 halo-dev/plugin-comment-widget#80 中一致的字体设置方案。

添加了三个 CSS 变量：

```
--halo-search-widget-base-font-size: ;			全局字体大小
--halo-search-widget-base-border-radius: ;	边框圆角
--halo-search-widget-base-font-family: ;			字体
```

/kind feature

```release-note
添加和字体相关的 CSS 变量
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

@ruibaby ruibaby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiewenhuang @JohnNiang @ruibaby