Expose BFloat in Python bindings#8255
Merged
steven-johnson merged 1 commit intohalide:mainfrom Jun 2, 2024
Merged
Conversation
There are two parts to support for BFloat16 in Python: 1) Ability to define kernels and AOT compile them [fixed in this PR] 2) Ability to call kernels from Python This fixes part 1, which is what I need for my use case. Part 2 is blocked on bfloat16 support in Python buffer protocols. See halide#6849 for more details.
abadams
approved these changes
Jun 2, 2024
steven-johnson
approved these changes
Jun 2, 2024
Contributor
steven-johnson
left a comment
There was a problem hiding this comment.
Thanks for the fix!
jansel
added a commit
to pytorch/pytorch
that referenced
this pull request
Jun 19, 2024
Requires halide/Halide#8255 ghstack-source-id: 237dae8 Pull Request resolved: #129036
jansel
added a commit
to pytorch/pytorch
that referenced
this pull request
Jun 22, 2024
Requires halide/Halide#8255 ghstack-source-id: 5c70a85 Pull Request resolved: #129036
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 29, 2024
Requires halide/Halide#8255 Pull Request resolved: #129036 Approved by: https://github.com/shunting314, https://github.com/eellison ghstack dependencies: #126417, #129025, #129026, #127506
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two parts to support for BFloat16 in Python:
This fixes part 1, which is what I need for my use case. Part 2 is blocked on bfloat16 support in Python buffer protocols. See #6849 for more details.