Skip to content

Conversation

@hai046
Copy link
Owner

@hai046 hai046 commented Jul 21, 2022

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

engine-flutter-autoroll and others added 30 commits July 7, 2022 05:34
* Ensure build is done in incremental mode.

This allows for faster bootstrapping of the compiler from previously created dill file.

Fixes #107183

* Avoid initializeFromDill in aot mode

* Update tests
* Pass URI converter from context to DDS

* Match change that will be merged

* Revert SDK web change
Add `fromDirectional` factory to `RelativeRect` for when an app needs to consider both TextDirection.ltr and TextDirection.rtl.

```
RelativeRect.fromDirectional(
    textDirection: textDirection,
    start: 10.0,
    top: 20.0,
    end: 30.0,
    bottom: 40.0,
);
```

Addresses #107058.
The pubRoot directory interface is being changed to promote adding and removing directories
* Fixed AnimatedSwitcher chain produced duplicates

* Fixed issue with global keys being copied

* trailing whitespace

* removed unused dependencies

* Fixed dependency loop
engine-flutter-autoroll and others added 29 commits July 20, 2022 04:53
* Check for bad characters in path on Windows build

* Doc comments

* Fix formatting

* Commenting/formatting

* Link to issue in comment

* Comments, formatting

* Global var rename
@hai046 hai046 merged commit a848a7f into hai046:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.