Skip to content

[framework] don't composite with a scale of 0.0#106982

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
jonahwilliams:scale_widget
Jul 7, 2022
Merged

[framework] don't composite with a scale of 0.0#106982
auto-submit[bot] merged 6 commits into
flutter:masterfrom
jonahwilliams:scale_widget

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

I'm pretty sure that 0.0 times anything is 0.0. Except for maybe infinity, but don't quote me on that.

Fixes #106974

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 2, 2022
@jonahwilliams jonahwilliams requested a review from flar July 2, 2022 00:13
Comment thread packages/flutter/lib/src/rendering/proxy_box.dart Outdated
@flar

flar commented Jul 2, 2022

Copy link
Copy Markdown
Contributor

I'm pretty sure that 0.0 times anything is 0.0. Except for maybe infinity, but don't quote me on that.

But a transform is a sum of 3 or 4 factors some of which can be zero... ;)

@flar flar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a typo nit...

Comment thread packages/flutter/lib/src/rendering/proxy_box.dart Outdated
Comment thread packages/flutter/lib/src/rendering/proxy_box.dart Outdated
Comment thread packages/flutter/lib/src/widgets/basic.dart
Comment thread packages/flutter/lib/src/widgets/basic.dart
Comment thread packages/flutter/lib/src/widgets/basic.dart Outdated
@jonahwilliams jonahwilliams requested a review from flar July 7, 2022 17:04

@flar flar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

Thanks @flar !

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit auto-submit Bot merged commit 1573934 into flutter:master Jul 7, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transform.scale and ScaleTransform should avoid painting/compositing when scale is 0

2 participants