Deterministic file adding order in compile_zstd()#162
Merged
gyscos merged 2 commits intogyscos:masterfrom Aug 31, 2022
Merged
Conversation
This is to make the build more deterministic. Note that `fs::read_dir()`'s behavior is platform-specific. We sort the returned result of `read_dir` to make the file addition order deterministic.
gyscos
reviewed
Aug 31, 2022
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
syncom
added a commit
to syncom/rust-cross-build-nix
that referenced
this pull request
Sep 12, 2022
Use a branch that has the reproducibility improvement gyscos/zstd-rs#162
syncom
added a commit
to syncom/rust-cross-build-nix
that referenced
this pull request
Sep 12, 2022
* Use tstd crate This is to reproduce an issue related to a recent tstd-rs change for aarch64 build. The problematic change in tstd is gyscos/zstd-rs@f0d8a12. * Repro tstd-rs linking issue In `Cargo.tomol` - Uncomment line for zstd rev="56c8b52b6d448e376e746fc062077f68febc03a3": builds successfully - Uncomment line for zstd rev="f0d8a12f0f520095cf26a0dac35b8d0939277add": causes build failure Build commands (with `cross-rs`) cross build --target=x86_64-unknown-linux-musl cross build --target=aarch64-unknown-linux-musl * Use zstd-rs fork that contains r10e patch for demo Use a branch that has the reproducibility improvement gyscos/zstd-rs#162
|
Hi, could you please make a release with this fix, so that it is easier to include in our openSUSE vendor tarballs? |
This was referenced Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make the build more deterministic.
Note that
fs::read_dir()'s behavior is platform-specific. We sort thereturned result of
read_dirto make the file addition orderdeterministic.