Extracted functions to static methods#113
Merged
Nyholm merged 2 commits intoguzzle:masterfrom Sep 19, 2020
GrahamCampbell:no-functions
Merged
Extracted functions to static methods#113Nyholm merged 2 commits intoguzzle:masterfrom GrahamCampbell:no-functions
Nyholm merged 2 commits intoguzzle:masterfrom
GrahamCampbell:no-functions
Conversation
9 tasks
Member
Author
Nyholm
approved these changes
Sep 19, 2020
Member
Nyholm
left a comment
There was a problem hiding this comment.
Thank you @GrahamCampbell for this.
I've reviewed it multiple times over the months and today I decided to be super picky and finish it all.
I found just one small thing that only "technically" could have a side effect. Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pairs with guzzle/guzzle#2712. After this is merged, we can tag 1.4.0.
TODO:
Mappings:
queueUtils::queuetaskUtils::taskpromise_forCreate::promiseForrejection_forCreate::rejectionForexception_forCreate::exceptionForiter_forCreate::iterForinspectUtils::inspectinspect_allUtils::inspectAllunwrapUtils::unwrapallUtils::allsomeUtils::someanyUtils::anysettleUtils::settleeachEach::ofeach_limitEach::ofLimiteach_limit_allEach::ofLimitAll!is_fulfilledIs::pendingis_fulfilledIs::fulfilledis_rejectedIs::rejectedis_settledIs::settledcoroutineCoroutine::ofNB The overall idea of these changes was approved by the original author, Michael: #108.