Restored support for PHP 5.5 and HHVM 3#110
Restored support for PHP 5.5 and HHVM 3#110Tobion merged 2 commits intoguzzle:masterfrom GrahamCampbell:php-55
Conversation
hhvm is not even supported by composer anymore and php 5.5 long eol. this way we can also update phpunit.
I think this should be v1.3.2 as there aren't any real features added since v1.3.1. In v1.4.0 we can then drop support for old php versions. |
|
1.3.2 is fine by me. We just need to change the branch alias from 1.3 to 1.4. |
|
Before the 1.3.2 release, the change log also needs updating. |
I don't think that's a good idea because:
|
|
What's your plan with v2 of promises? What's the breaking change you plan? |
Adding scalar type hints, and removing the functions file, like in Guzzle, because global functions don't play nice when a different version of the package is installed globally with composer to locally, and leads to bugs like guzzle/guzzle#2511. See guzzle/guzzle#2546. The plan would be to add the new static class methods in 1.4.0 and deprecate the functions, then remove in 2.0.0. Some work already started at #108. |
This PR restores support for PHP 5.5 and HHVM 3, to match Guzzle 6.5's supported versions. I have tested against the same version of HHVM that Guzzle 6.5 tests against. After this, I think we are good to tag
v1.4.0.NB The hacks I added in this PR can be undone in
v2.0.0, which will certainly drop HHVM and PHP less than 7.2.