Merged
Conversation
* Updates the .gitignore file to ignore custom variants (except for the example variant provided as well as custom workspace folders * Unifies the way the displayed URL is acquired
Contributor
|
Please split the merge request in two separate merge requests. |
Owner
|
@stappersg Why are you asking for this to be split? |
Owner
|
Seems good to me and will merge. Just waiting a little bit more to get a reply from @stappersg if he/she sees something I am not. |
Contributor
To have commits that only change one thing at a time. |
Owner
|
Indeed its good practice. And if I would want to merge only one of the changes I would ask that. However the developer count is so low (aka I am the only maintainer), that bundling up saves time. When we have a massive developer pool it would make more sense. |
dwarf6
pushed a commit
to dwarf6/FullPageOS64
that referenced
this pull request
Feb 19, 2026
…dling URL-Handling / .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues I found while working on a custom variant of fullpageos.
.gitignore file
The gitignore file is updated to ignore custom variants (except for the example variant) as well as workspaces of custom variants.
url handling
Multiple scripts use some type of URL with quite a few different ways this is handled:
run_onepageoshas the following URL hardcoded:http://localhost/FullPageDashboardsafe_refreshuses$(cat /boot/fullpageos.txt)fullpageos.txt(I did not test if that actually causes issues but replaced it regardless)start_chromium_browseruses$(head -n 1 /boot/fullpageos.txt | sed -e "s/{serial}/${SERIAL}/g"get_urlscript