Conversation
See guardian/maintaining-scala-projects#11 for more details.
Contributor
|
Seen on ADMIN-PROD (merged by @JamieB-gu 12 minutes and 57 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @JamieB-gu 13 minutes and 27 seconds ago)
|
rtyley
added a commit
to rtyley/librarymanagement
that referenced
this pull request
Jul 10, 2025
The current deprecation messages for `sonatypeRepo()` & `sonatypeOssRepos()` (added with sbt#517) say: > use the following instead: resolvers += Resolver.sonatypeCentral**Snapshots** ...but following this advice can expose projects to using **snapshot** artifacts when they did not previously! This is unfortunate, as snapshots artifacts are inherently more risky, due to being mutable. For example, invocations of `sonatypeOssRepos()` like [this](https://github.com/guardian/frontend/blob/76234e013f550ac600fbf0bb924c19a1a6165295/project/plugins.sbt#L10): ```scala resolvers ++= Resolver.sonatypeOssRepos("releases") ``` ...should _not_ be replaced by `sonatypeCentralSnapshots()`, as, AFAIK, only non-snapshot releases would be in `sonatypeOssRepos("releases")`. In an ideal world (where snapshots are not, and were not, being used!) the `sonatypeOssRepos()` entry should just be [removed](guardian/frontend#28084) (as I don't _think_ there is any useful equivalent now that we're using Central Portal? In the old days we could get our artifacts a little quicker with `sonatypeOssRepos()`). Only if snapshots are in use should users replace the entry with `sonatypeCentralSnapshots()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See guardian/maintaining-scala-projects#11 for more details.