fix: Ensure the healthcheck for a Target Group is legal#762
Merged
Conversation
A Target Group's healthcheck must have a timeout lower than the interval. Annoyingly, AWS CDK doesn't catch this and will happily synth a stack that violates this rule. This change checks that `timeout` is less than `interval` and throws otherwise to prevent synth from completing. See: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-elb-health-check.html#cfn-elb-healthcheck-timeout.
jacobwinch
approved these changes
Aug 26, 2021
Contributor
jacobwinch
left a comment
There was a problem hiding this comment.
Thanks for fixing this 💯
Contributor
|
🎉 This PR is included in version 23.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
akash1810
added a commit
to guardian/cdk-playground
that referenced
this pull request
Aug 26, 2021
This is to fix a healthcheck issue that's preventing the CFN stack from updating. See: guardian/cdk#762
Member
Author
|
This has been fixed upstream now too in v1.121.0 - aws/aws-cdk#16107. Update: the change is only available when calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
A Target Group's healthcheck must have a timeout lower than the interval.
Annoyingly, AWS CDK doesn't catch this and will happily synth a stack that violates this rule. This change checks that
timeoutis less thanintervaland throws otherwise to prevent synth from completing.See: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-elb-health-check.html#cfn-elb-healthcheck-timeout.
This follows the changes made in #738.
Does this change require changes to existing projects or CDK CLI?
No.
Does this change require changes to the library documentation?
I don't think so.
How to test
See added test.
How can we measure success?
Illegal CloudFormation is caught early (at build time rather than runtime).
Have we considered potential risks?
n/a