grpc/service_config: Add service_name field to grpclb config.#73
grpc/service_config: Add service_name field to grpclb config.#73easwars merged 3 commits intogrpc:masterfrom
Conversation
This will be used by rls to override the name of the target to be sent to the remote balancer.
| // the list in order and stop at the first policy that they support. | ||
| repeated LoadBalancingConfig child_policy = 1; | ||
| // If specified, overrides the name of the target to be sent to the balancer. | ||
| optional string target_name = 2; |
There was a problem hiding this comment.
This is proto3, so no need for "optional".
|
Also, realized that we don't have a BUILD rule for this proto. I'm not sure if that is by design. I made the BUILD rule changes locally to be able to build this proto. I could send a PR if it makes sense to do so. |
I tried to put together a PR to add the BUILD rule for this a while back (see #59), but I ran into problems and haven't found time to figure out what was wrong. If you want to pick that up and drive it forward, that would be great. |
|
Uhh... this is unnecessary/awkward in Java. grpclb observes the |
| repeated LoadBalancingConfig child_policy = 1; | ||
| // Optional. If specified, overrides the name of the target to be sent to | ||
| // the balancer. | ||
| string target_name = 2; |
There was a problem hiding this comment.
@markdroth and I talked. I understand now that we need such a field, and this isn't a normal "target" string. Let's go with service_name, to try to match the nomenclature we're using in the grpclb protocol.
To reflect changes made in grpc/grpc-proto#73
To reflect changes made in grpc/grpc-proto#73
This will be used by rls to override the name of the target to be sent
to the remote balancer.