grpc-js: Re-add a couple of accidentally removed HTTP/2 session settings#3023
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.14.xfrom Nov 7, 2025
Merged
Conversation
emil10001
approved these changes
Nov 7, 2025
Member
emil10001
left a comment
There was a problem hiding this comment.
In the future, we may want to figure out a couple of things:
- limit node's ability to allocate only memory that is available on the machine (as opposed to setting a fixed value that may be larger or smaller than the actual available memory
- figure out how to clean up memory for long-running node processes that we are operating in
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These settings were accidentally removed when refactoring the transport in #2855, as noted in #2855 (comment). This may have caused a regression that increased the frequency of RESOURCE_EXHAUSTED errors.