grpc-js: Add security connector, rework connection establishment#2855
Merged
murgatroid99 merged 2 commits intogrpc:masterfrom Nov 23, 2024
Merged
Conversation
2715c80 to
f154954
Compare
jpuh
reviewed
Oct 23, 2025
| * disable enforcement of the limit. Some testing indicates that Node's | ||
| * behavior degrades badly when this limit is reached, so we solve that | ||
| * by disabling the check entirely. */ | ||
| connectionOptions.maxSessionMemory = Number.MAX_SAFE_INTEGER; |
Member
Author
There was a problem hiding this comment.
It should still be there. It looks like it got lost in the shuffle, along with the maxSendHeaderBlockLength setting on line 688.
Member
Author
There was a problem hiding this comment.
It is now restored in version 1.14.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the
ChannelCredentialsAPI so that instead of providing the connection options which are used to establish a TLS connection, it provides aSecurityConnector, which is created using information about a specific subchannel, and is responsible for establishing TLS connections on top of TCP connections.With this change, the steps of establishing an HTTP/2 session are more cleanly divided: