netty:Auto adjust BDP ping frequency#9650
Merged
larry-safran merged 13 commits intogrpc:masterfrom Dec 22, 2022
Merged
Conversation
…m decrement 1 to simply 1.
Contributor
Author
|
@ejona86 please review |
* Split for loop out into its own test * Change setDataSizeAndSincePing to set time to current time rather than 1 second (or nanosecond) previous.
ejona86
reviewed
Nov 18, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
Sending what I have, in whatever state it happens to be.
Contributor
Author
|
@ejona86 ping |
ejona86
reviewed
Dec 21, 2022
ejona86
approved these changes
Dec 21, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
I'm a bit concerned about whether the NettyClientStream.start() blows up in our face, but assuming it doesn't, consider the comments and LGTM.
…w happens after check to start a ping.
…fer return a byte[].
…fer return a byte[]. Remove extra factory NettyServerHandler.newHandler
larry-safran
added a commit
that referenced
this pull request
Jan 13, 2023
This reverts commit f5e8459.
larry-safran
added a commit
that referenced
this pull request
Jan 13, 2023
larry-safran
added a commit
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only initiate a BDP ping after every X bytes of data where X is a multiple of the window size that increases when the window isn't changing.
Added a ticker to the Netty handlers so that bandwidth could be properly controlled from tests.
Fixes #8260