xds: Build third-party protos in separate build step#9269
Merged
ejona86 merged 7 commits intogrpc:masterfrom Jul 7, 2022
Merged
xds: Build third-party protos in separate build step#9269ejona86 merged 7 commits intogrpc:masterfrom
ejona86 merged 7 commits intogrpc:masterfrom
Conversation
Member
|
Looks like the build still fails |
Member
Author
|
Ugh. This is going to take some more to deal with the dependencies used by thirdparty build but not by xds itself. I could workaround that by using compileOnly dependencies in thirdparty and re-declaring them for xds, but... Part of this trouble is made worse because the dependencies are sort of wonky to begin with to deal with shadow. |
This dramatically shortens build time, even for full builds. A full assemble of xds on my laptop goes from 1m 46s to 33s at least because errorprone is disabled for the protos.
bcee635 to
e6d2c90
Compare
Member
Author
|
@YifeiZhuang, this should be working now. |
Member
Author
|
Ugh. OOMing. |
Member
Author
|
@YifeiZhuang, the build OOMing is now resolved. |
YifeiZhuang
approved these changes
Jul 7, 2022
Member
YifeiZhuang
left a comment
There was a problem hiding this comment.
Thank you for the optimization and simplification, it looks great!
ejona86
added a commit
to ejona86/grpc
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". grpc/grpc-java#9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit. b/238438006
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". grpc#9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". grpc#9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit. b/238334438
ejona86
added a commit
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". #9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit. b/238334438
ejona86
added a commit
to grpc/grpc
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". grpc/grpc-java#9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit. b/238438006
drfloob
pushed a commit
to drfloob/grpc
that referenced
this pull request
Jul 8, 2022
Should fix "Expiring Daemon because JVM heap space is exhausted". grpc/grpc-java#9269 probably pushed the build over the edge, but there's been evidence via flakes for a good while that we've been reaching the limit. b/238438006
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dramatically shortens build time, even for full builds. A full
assemble of xds on my laptop goes from 1m 46s to 33s at least because
errorprone is disabled for the protos.
CC @sergiitk