interop-testing: add xds test service to set healthy/unhealthy#7127
Merged
ericgribkoff merged 1 commit intogrpc:masterfrom Jun 16, 2020
Merged
interop-testing: add xds test service to set healthy/unhealthy#7127ericgribkoff merged 1 commit intogrpc:masterfrom
ericgribkoff merged 1 commit intogrpc:masterfrom
Conversation
84e03cf to
5a16d56
Compare
dapengzhang0
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple service to the XdsTestServer to allow dynamically changing the server's health status to/from serving/not-serving. The existing xds tests simply kill the VM to simulate an unhealthy server - in retrospect this approach seems suboptimal generally, but in particular it made it impossible to test the new gentle failover feature which relies on VMs existing but reporting unhealthy. Now the test runner can simply send an RPC to the server and have it ~instantly switch between health statuses rather than waiting for VMs to start/stop.