all: let interop test use shaded dependency correctly#6780
Merged
dapengzhang0 merged 5 commits intogrpc:masterfrom Feb 28, 2020
Merged
all: let interop test use shaded dependency correctly#6780dapengzhang0 merged 5 commits intogrpc:masterfrom
dapengzhang0 merged 5 commits intogrpc:masterfrom
Conversation
ejona86
reviewed
Feb 27, 2020
| project(':grpc-testing-proto'), | ||
| project(':grpc-testing'), | ||
| libraries.truth | ||
| shadow project(':grpc-core') |
Member
There was a problem hiding this comment.
I figured out why this is here: it is necessary for the pom to include a dependency on grpc-core.
Contributor
Author
There was a problem hiding this comment.
I see. Changed back.
xds/build.gradle
Outdated
|
|
||
| compileOnly libraries.javax_annotation | ||
| compileOnly libraries.javax_annotation, | ||
| // The unshaded netty_epoll should not be a transitive dependency. |
Member
There was a problem hiding this comment.
This comment sort of just reexplains what a compileOnly dependency is. Instead how about:
// At runtime use the epoll included in grpc-netty-shaded
ejona86
approved these changes
Feb 27, 2020
Contributor
Author
|
gae-interop-testing was failing https://source.cloud.google.com/results/invocations/24432bbe-0f09-4149-89dd-7190c766cf73/targets assertTrue(builder instanceof NettyChannelBuilder);
((NettyChannelBuilder) builder).flowControlWindow(65 * 1024); |
Member
|
This PR caused a regression in the ALTS tests. https://source.cloud.google.com/results/invocations/691d9965-fea1-487d-b606-352a5234039e/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_interop_toprod/log It can be trivially reproduced by running on your machine (no need for any other setup): @dapengzhang0, we should probably revert this change while we try to figure out the solution. |
|
Cc: @jtattermusch |
dapengzhang0
added a commit
to dapengzhang0/grpc-java
that referenced
this pull request
Mar 2, 2020
)" This reverts commit c5f48b8.
dapengzhang0
added a commit
that referenced
this pull request
Mar 2, 2020
This reverts commit c5f48b8. (#6780) Revert because caused a regression in the ALTS tests. https://source.cloud.google.com/results/invocations/691d9965-fea1-487d-b606-352a5234039e/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_interop_toprod/log 2020-03-01 20:02:12,491 Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils at io.grpc.alts.CheckGcpEnvironment.isRunningOnGcp(CheckGcpEnvironment.java:69) at io.grpc.alts.CheckGcpEnvironment.isOnGcp(CheckGcpEnvironment.java:44) at io.grpc.alts.ComputeEngineChannelBuilder.(ComputeEngineChannelBuilder.java:62) at io.grpc.alts.ComputeEngineChannelBuilder.forTarget(ComputeEngineChannelBuilder.java:72) at io.grpc.alts.ComputeEngineChannelBuilder.forAddress(ComputeEngineChannelBuilder.java:77) at io.grpc.testing.integration.TestServiceClient$Tester.createChannel(TestServiceClient.java:399) at io.grpc.testing.integration.AbstractInteropTest.setUp(AbstractInteropTest.java:309) at io.grpc.testing.integration.TestServiceClient.setUp(TestServiceClient.java:198) at io.grpc.testing.integration.TestServiceClient.main(TestServiceClient.java:56) Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.SystemUtils at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 9 more
dapengzhang0
added a commit
to dapengzhang0/grpc-java
that referenced
this pull request
Mar 2, 2020
…grpc#6780)"" This reverts commit 1df7d7e.
Contributor
Author
|
Trying to fix the issue of missing transitive dependencies for shadow configuration in #6792. |
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
)" This reverts commit c5f48b8. (grpc#6780) Revert because caused a regression in the ALTS tests. https://source.cloud.google.com/results/invocations/691d9965-fea1-487d-b606-352a5234039e/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_interop_toprod/log 2020-03-01 20:02:12,491 Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils at io.grpc.alts.CheckGcpEnvironment.isRunningOnGcp(CheckGcpEnvironment.java:69) at io.grpc.alts.CheckGcpEnvironment.isOnGcp(CheckGcpEnvironment.java:44) at io.grpc.alts.ComputeEngineChannelBuilder.(ComputeEngineChannelBuilder.java:62) at io.grpc.alts.ComputeEngineChannelBuilder.forTarget(ComputeEngineChannelBuilder.java:72) at io.grpc.alts.ComputeEngineChannelBuilder.forAddress(ComputeEngineChannelBuilder.java:77) at io.grpc.testing.integration.TestServiceClient$Tester.createChannel(TestServiceClient.java:399) at io.grpc.testing.integration.AbstractInteropTest.setUp(AbstractInteropTest.java:309) at io.grpc.testing.integration.TestServiceClient.setUp(TestServiceClient.java:198) at io.grpc.testing.integration.TestServiceClient.main(TestServiceClient.java:56) Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.SystemUtils at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 9 more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: This PR was reverted by #6791