Skip to content

Conversation

@shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Aug 28, 2025

Fixes #7690

VERIFIED:

./buildscripts/kokoro/macos.sh 
...
...
BUILD SUCCESSFUL
lipo -archs $(find ./mvn-artifacts -name "protoc-gen-grpc-java-*-osx-aarch_64.exe")

x86_64 arm64

@shivaspeaks shivaspeaks changed the title add support for aarch64 add support for macos aarch64 Aug 28, 2025
@shivaspeaks shivaspeaks requested a review from ejona86 August 28, 2025 15:53
@shivaspeaks shivaspeaks marked this pull request as ready for review August 28, 2025 15:53
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reverting the upload_artifacts.sh change.

@shivaspeaks shivaspeaks added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Sep 12, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Sep 12, 2025
@shivaspeaks shivaspeaks changed the title add support for macos aarch64 Add support for macOS aarch64 with universal binary Sep 13, 2025
@shivaspeaks shivaspeaks merged commit fe54dd6 into grpc:master Sep 13, 2025
26 of 29 checks passed
@shivaspeaks shivaspeaks deleted the protoc-gen branch September 13, 2025 08:07
addEnvArgs("CXXFLAGS", cppCompiler.args)
addEnvArgs("CPPFLAGS", cppCompiler.args)
if (project.hasProperty('buildUniversal') &&
project.getProperty('buildUniversal').toBoolean() &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project.findProperty('buildUniversal')?.toBoolean() without the previous check

AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protoc-gen-grpc-java not available on apple m1

5 participants