Skip to content

xds: xdsClient caches transient error for new watchers #12262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shivaspeaks merged 5 commits into from
Aug 19, 2025
Merged

xds: xdsClient caches transient error for new watchers #12262

shivaspeaks merged 5 commits into from
Aug 19, 2025

Conversation

@shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Aug 7, 2025 •
edited
Loading

Fixes #11672

@shivaspeaks shivaspeaks marked this pull request as ready for review August 7, 2025 13:50
kannanjgithub
kannanjgithub requested changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@kannanjgithub kannanjgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

ejona86
ejona86 approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I really want to kill errorDescription, as it is just lastError = Status.INVALID_ARGUMENT. However, some of the fallback code is using errorDescription in really weird ways, so we'd have to clean that up first.

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Aug 19, 2025
kannanjgithub
kannanjgithub previously approved these changes Aug 19, 2025
View reviewed changes
@kannanjgithub kannanjgithub dismissed their stale review August 19, 2025 11:56

Replied in comments

@shivaspeaks shivaspeaks merged commit 2039266 into grpc:master Aug 19, 2025
16 checks passed
@shivaspeaks shivaspeaks deleted the xdsClient-cache-transient-error branch August 19, 2025 16:11
kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request Aug 19, 2025
@shivaspeaks @kannanjgithub
xds: xdsClient caches transient error for new watchers (grpc#12262)
760b649
@kannanjgithub kannanjgithub mentioned this pull request Aug 19, 2025
Merged
kannanjgithub added a commit that referenced this pull request Aug 20, 2025
@kannanjgithub @shivaspeaks
xds: xdsClient caches transient error for new watchers (v1.75.x backp…
14fd8ef 
…ort) (#12291)

Backport of #12262 to v1.75.x.
---
Fixes #11672

Co-authored-by: MV Shiva <speakupshiva@gmail.com>
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
@shivaspeaks @AgraVator
xds: xdsClient caches transient error for new watchers (grpc#12262)
d09a0f0
@AgraVator AgraVator removed the TODO:backport PR needs to be backported. Removed after backport complete label Oct 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kannanjgithub kannanjgithub kannanjgithub approved these changes

@ejona86 ejona86 Awaiting requested review from ejona86

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

XdsClient does not cache onError for new watchers

4 participants

@shivaspeaks @ejona86 @kannanjgithub @AgraVator