Simplify RobolectricBinderSecurityTest #12058
Merged
+57
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdcormie
commented
May 9, 2025
- Use INSTRUMENTATION_TEST @LooperMode to avoid custom Executors and idleLoopers() toil.
- No android.app.Service is actually needed with Robolectric.
- Use INSTRUMENTATION_TEST @LooperMode to avoid custom Executors and idleLoopers() toil. - No android.app.Service is actually needed with Robolectric.
mateusazis
reviewed
May 9, 2025
Contributor
mateusazis
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Looks much better!
binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java
Outdated
Show resolved
Hide resolved
binder/src/test/java/io/grpc/binder/RobolectricBinderSecurityTest.java
Outdated
Show resolved
Hide resolved
mateusazis
approved these changes
May 9, 2025
Member
Author
|
ejona86: Reviewer doesn't have write access. Could you please approve? |
ejona86
approved these changes
May 9, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Jun 23, 2025
- Use INSTRUMENTATION_TEST @LooperMode to avoid custom Executors and idleLoopers() toil. - No android.app.Service is actually needed with Robolectric.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.