compiler: Use fully qualified String in codegen#10321
Merged
larry-safran merged 1 commit intogrpc:masterfrom Jun 29, 2023
pkwarren:pkw/issue-10316
Merged
compiler: Use fully qualified String in codegen#10321larry-safran merged 1 commit intogrpc:masterfrom pkwarren:pkw/issue-10316
larry-safran merged 1 commit intogrpc:masterfrom
pkwarren:pkw/issue-10316
Conversation
pkwarren
commented
Jun 28, 2023
Contributor
Author
There was a problem hiding this comment.
I noticed this when building on arm64 debian bookworm (latest stable release). Otherwise tests are passing.
> Task :grpc-compiler:checkArtifacts FAILED
Checking format of build/artifacts/java_plugin/protoc-gen-grpc-java.exe
Format=elf64-littleaarch64
Assertion failed: "elf64-littleaarch64" == "elf64-little"
File "check-artifact.sh", line 63
Currently, the gRPC compiler isn't properly using the fully qualified string name `java.lang.String` instead of `String`. Update the generator to use the `$String$` alias to avoid compile issues with protobuf messages called String. Fixes #10316.
Contributor
Author
|
@ejona86 - Are you able to review this change? Thanks for helping me get it complied. |
ejona86
approved these changes
Jun 29, 2023
larry-safran
approved these changes
Jun 29, 2023
Contributor
Author
|
@larry-safran / @ejona86 - I noticed one of the kokoro builds was failing on Android. It appears that those generated files need to be regenerated as well. I was building with I was going to raise a PR which manually fixed those, but if one of you have a fully working build environment, can you check those in? Thanks! |
Member
|
I'll fix it. |
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Jun 29, 2023
Currently, the gRPC compiler isn't properly using the fully qualified string name `java.lang.String` instead of `String`. Update the generator to use the `$String$` alias to avoid compile issues with protobuf messages called String. Fixes grpc#10316.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the gRPC compiler isn't properly using the fully qualified string name
java.lang.Stringinstead ofString. Update the generator to use the$String$alias to avoid compile issues with protobuf messages called String.Fixes #10316.