android,binder,cronet: .aar file when publishing#10138
Merged
temawi merged 2 commits intogrpc:masterfrom May 5, 2023
Merged
Conversation
b25428b to
c1a3afe
Compare
ejona86
approved these changes
May 5, 2023
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 5, 2023
temawi
added a commit
that referenced
this pull request
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgraded Android Gradle Plugin no longer played nice with the
android-maven-publishplugin used earlier to produce Android library .aar files. No .aar files were being published at all.This removes the android-maven-publish plugin that is no longer needed with the newer version of AGP and updates the
grpc-android,grpc-binderandgrpc-cronetto use the native Android library publishing features of AGP.Using the
grpc-androidproject as an example, before these changes the files produced by the publishing step were:After the change get get:
The
diffoutput from comparing the old POM with the new is: