alts: Enable user to configure max number of concurrent ALTS handshakes.#10016
Merged
temawi merged 5 commits intogrpc:masterfrom Apr 10, 2023
Merged
Conversation
Contributor
Author
|
@temawi Would you be able to help review this PR? |
temawi
approved these changes
Apr 10, 2023
Comment on lines
+57
to
+58
| @VisibleForTesting | ||
| static final String ALTS_MAX_CONCURRENT_HANDSHAKES_ENV_VARIABLE = |
Contributor
There was a problem hiding this comment.
Looks like you can remove the @VisibleForTesting on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic is straightforward: attempt to read the GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES environment variable and, if it set to an integer, instantiate the handshake queues based on this integer.
Based on go/grpc-alts-concurrent-handshake-cap. See grpc/grpc#32672 for a comparison with the C-core logic.