Skip to content

grpc: Remove ErrRetriesExhausted type in favor of error string#9105

Merged
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:remove-retry-error-type
Apr 30, 2026
Merged

grpc: Remove ErrRetriesExhausted type in favor of error string#9105
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:remove-retry-error-type

Conversation

@arjan-bal

@arjan-bal arjan-bal commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Addresses: #7023

This change removes the ErrRetriesExhausted error type introduced in #8894. The original requirement was only to add information to the error message, not to provide the ability to programmatically inspect error types. This PR keeps the updated error message but removes the new error type. Since #7023 hasn't been released yet, this is not a breaking change.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.81 Release milestone Apr 30, 2026
@arjan-bal arjan-bal added the Type: Feature New features or improvements in behavior label Apr 30, 2026
@arjan-bal arjan-bal changed the title remove retry exhausted error type grpc: Remove ErrRetriesExhausted type in favor of error string Apr 30, 2026
@arjan-bal arjan-bal requested review from dfawley and easwars April 30, 2026 17:18
@codecov

codecov Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.12%. Comparing base (3d82ab3) to head (d2e6d32).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9105      +/-   ##
==========================================
+ Coverage   83.08%   83.12%   +0.03%     
==========================================
  Files         413      413              
  Lines       33484    33484              
==========================================
+ Hits        27821    27834      +13     
+ Misses       4240     4230      -10     
+ Partials     1423     1420       -3
Files with missing lines Coverage Δ
stream.go 82.33% <100.00%> (+0.22%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars assigned arjan-bal and unassigned easwars Apr 30, 2026
@arjan-bal arjan-bal merged commit 850cc54 into grpc:master Apr 30, 2026
15 of 18 checks passed
@arjan-bal arjan-bal mentioned this pull request Apr 30, 2026
Merged
arjan-bal added a commit that referenced this pull request May 4, 2026
@arjan-bal
Cherry-pick #9105 to 1.81.x (#9106)
96748f9 
Addresses: #7023

Original PR: #9105

RELEASE NOTES:
* grpc: enhance RPC failure error messages to indicate when retries are
exhausted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@easwars easwars easwars approved these changes

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@dfawley dfawley

@arjan-bal arjan-bal

Labels

Type: Feature New features or improvements in behavior

Projects

None yet

Milestone

1.81 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@arjan-bal @easwars @dfawley