Skip to content

grpc: improve the docstring for StreamServerInterceptor#8823

Merged
easwars merged 2 commits into
grpc:masterfrom
easwars:streaming_server_interceptor
Jan 13, 2026
Merged

grpc: improve the docstring for StreamServerInterceptor#8823
easwars merged 2 commits into
grpc:masterfrom
easwars:streaming_server_interceptor

Conversation

@easwars

@easwars easwars commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #8798

RELEASE NOTES: none

@easwars easwars added the Type: Documentation Documentation or examples label Jan 12, 2026
@easwars easwars added this to the 1.79 Release milestone Jan 12, 2026
@easwars easwars requested a review from dfawley January 12, 2026 22:07
@codecov

codecov Bot commented Jan 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (629ef39) to head (a1fec28).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8823      +/-   ##
==========================================
+ Coverage   83.22%   83.24%   +0.02%     
==========================================
  Files         417      414       -3     
  Lines       32920    32753     -167     
==========================================
- Hits        27397    27265     -132     
+ Misses       4108     4078      -30     
+ Partials     1415     1410       -5     
Files with missing lines Coverage Δ
stream.go 81.65% <ø> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread interceptor.go
// complete the RPC.
// StreamServerInterceptor provides a hook to intercept the execution of a
// streaming RPC on the server.
// srv is the service implementation on which the RPC was invoked, and needs to

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an extra blank line here (//) or rewrap?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dfawley dfawley assigned easwars and unassigned dfawley Jan 13, 2026
@easwars easwars merged commit bb2f97f into grpc:master Jan 13, 2026
14 checks passed
@easwars easwars deleted the streaming_server_interceptor branch January 13, 2026 19:38
mbissa pushed a commit to mbissa/grpc-go that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Documentation or examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve documentation for srv parameter in stream interceptor

2 participants