encoding: add a test for unsupported server codec#8819
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8819 +/- ##
==========================================
+ Coverage 83.22% 83.26% +0.04%
==========================================
Files 417 417
Lines 32920 32920
==========================================
+ Hits 27397 27412 +15
+ Misses 4108 4096 -12
+ Partials 1415 1412 -3 🚀 New features to boost your workflow:
|
dfawley
approved these changes
Jan 12, 2026
dfawley
left a comment
Member
There was a problem hiding this comment.
The behavior change scares me a bit, but it's always good to have more tests, regardless.
atollena
pushed a commit
to zhiyanfoo/grpc-go
that referenced
this pull request
Jan 15, 2026
Addresses grpc#1824 This PR adds a test for the case where the client specifies a codec that is unsupported on the server. In a previous PR, we had added a warning for this scenario. In a subsequent PR, we will add an environment variable to gate the new behavior, where the server will not default to using the `proto` codec for unsupported codecs, but instead will fail the request. RELEASE NOTES: None
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
Addresses grpc#1824 This PR adds a test for the case where the client specifies a codec that is unsupported on the server. In a previous PR, we had added a warning for this scenario. In a subsequent PR, we will add an environment variable to gate the new behavior, where the server will not default to using the `proto` codec for unsupported codecs, but instead will fail the request. RELEASE NOTES: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1824
This PR adds a test for the case where the client specifies a codec that is unsupported on the server. In a previous PR, we had added a warning for this scenario. In a subsequent PR, we will add an environment variable to gate the new behavior, where the server will not default to using the
protocodec for unsupported codecs, but instead will fail the request.RELEASE NOTES: None